tickets/DM-41840: Implement new detection tasks #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taranu
reviewed
Oct 11, 2024
taranu
reviewed
Oct 15, 2024
|
|
||
| peaks = cT.Input( | ||
| doc="Catalog of detected peak positions", | ||
| name="{inputCoaddName}_coadd_multiband_peaks", |
There was a problem hiding this comment.
Is this in anticipation of RFC-1049? I debated this myself; it might be premature to move to full snake case before it's implemented and deepCoadd changes.
There was a problem hiding this comment.
I think it's fine to do this now. Jim seemed to give his support to this naming scheme: https://lsstc.slack.com/archives/CAVQQ6SBX/p1726691030465659?thread_ts=1726688938.272269&cid=CAVQQ6SBX Besides, I don't see the need to create one more thing that needs to be changed shortly anyway.
python/lsst/meas/extensions/scarlet/multiBandPeakDetectionTask.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.