DM-41209: Switch to pyproject.toml #5
Conversation
taranu
force-pushed
the
tickets/DM-41209
branch
from
954658d
to
f7fabd4
Compare
| "matplotlib", | ||
| "numpy", | ||
| "pydantic", | ||
| "pytest", |
There was a problem hiding this comment.
pytest is presumably not a run time dependency? You can add a separate optional dependencies entry in the the file and declare test dependencies in there.
[project.optional-dependencies]
test = [
"pytest >= 3.2",
]There was a problem hiding this comment.
Is that v3.2 minimum from a feature we're using in the stack or a compatibility issue?
More generally I couldn't figure out how to set minimum versions of anything for standalone packages like multiprofit, beyond that I made a py3.8 conda env and confirmed that it wouldn't work. Is there anything else I could/should do other than follow changes to other stack packages like resources/daf_butler?
There was a problem hiding this comment.
The 3.2 was just an example. It's likely wildly out of date. The point is to separate runtime deps from testing deps. Minimum versions are done the same way pytest <5,>=3.2 or something.
| "galsim", | ||
| "gauss2d", | ||
| "gauss2dfit", | ||
| "lsst-multiprofit", |
There was a problem hiding this comment.
This implies you are putting lsst-multiprofit on PyPI. Are you? I know this package itself can't go on PyPI because of the meas_base dependency.
There was a problem hiding this comment.
Does it imply availability on PyPI? Once multiprofit is scons-built, it shows up on pip list with the same version as it would if pip-installed. On the other hand, gauss2d(fit) don't when eups-built because I skipped the pip install step, figuring it would be unnecessary. But perhaps none of this matters because presumably this package won't be pip-installable until all of the dependencies like meas_base are too...
There was a problem hiding this comment.
pip will read this dependency list. It will, I think, just try to see if they are installed before trying to check on PyPI so if everything has happened beforehand if will be fine. One issue you will have is that lsst-multiprofit is the name here but EUPS thinks it's called multiprofit and we don't yet install the proper egg information to allow importlib.metadata to work out the right answer -- that's something I'd like to fix though.
Yes, none of this matters because meas_base is not going to be pip installable.
| requires-python = ">=3.10" | ||
| keywords = ["astronomy", "lsst", "galaxy"] | ||
| license = {file = "LICENSE"} | ||
| classifiers = [ |
There was a problem hiding this comment.
In theory there should be the GPL license classifier here.
taranu
force-pushed
the
tickets/DM-41209
branch
from
b1508ca
to
aeb7632
Compare
taranu
force-pushed
the
tickets/DM-41209
branch
from
aeb7632
to
e21700a
Compare
This also adds the lsst namespace prefix to multiprofit imports.