DM-47256: Remove apply_schema_to_tables flag #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
==========================================
- Coverage 92.89% 92.88% -0.01%
==========================================
Files 23 23
Lines 2884 2880 -4
Branches 290 289 -1
==========================================
- Hits 2679 2675 -4
Misses 118 118
Partials 87 87 ☔ View full report in Codecov by Sentry. |
This flag is redundant, because enabling the apply_schema_to_metadata flag will already result in the tables being associated to the schema.
JeremyMcCormick
force-pushed
the
tickets/DM-47256
branch
from
379deb3 to
06df0be
Compare
andy-slac
approved these changes
Dec 7, 2024
JeremyMcCormick
changed the title
JeremyMcCormick
force-pushed
the
tickets/DM-47256
branch
from
06df0be to
e28e6f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag is redundant, because enabling
apply_schema_to_metadataon theMetaDataBuilderwill already result in the tables being associated to the schema correctly.Checklist
docs/changes