Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-45133: Set xtype on timestamp columns #117

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JeremyMcCormick
Copy link
Collaborator

@JeremyMcCormick JeremyMcCormick commented Nov 27, 2024

  • Add a validator to automatically set the votable_xtype to "timestamp" on Felis timestamp columns.

Checklist

  • Ran Jenkins
  • Added a release note for user-visible changes to docs/changes

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.37%. Comparing base (c5a10cf) to head (b7a3565).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   92.35%   92.37%   +0.02%     
==========================================
  Files          21       21              
  Lines        2615     2623       +8     
  Branches      257      258       +1     
==========================================
+ Hits         2415     2423       +8     
  Misses        127      127              
  Partials       73       73              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeremyMcCormick JeremyMcCormick changed the title DM-45133 DM-45133: Set xtype on timestamp columns Nov 28, 2024
@JeremyMcCormick JeremyMcCormick force-pushed the tickets/DM-45133 branch 2 times, most recently from f9251e6 to f301416 Compare December 4, 2024 23:56
@gpdf
Copy link

gpdf commented Feb 14, 2025

@JeremyMcCormick Is this reviewable at this time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants