DM-41705: Fix RemoteButler import #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed an implicit dependency on "fastapi" when loading the RemoteButler class. This was causing RemoteButler import to fail on RSP.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #905 +/- ##
==========================================
- Coverage 87.72% 87.72% -0.01%
==========================================
Files 285 285
Lines 36744 36743 -1
Branches 7690 7690
==========================================
- Hits 32233 32232 -1
Misses 3340 3340
Partials 1171 1171 ☔ View full report in Codecov by Sentry. |
timj
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
This looks okay. I might quibble that server models are needed by both server and by remote butler and so putting them in either server or remote_butler seems wrong but I have no better place to suggest (previously they were treated as a shared model in core).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes