DM-25972: Investigate MySQL/MariaDB #334
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-25972
branch
from
f131405 to
8c8964f
Compare
timj
force-pushed
the
tickets/DM-25972
branch
from
8c8964f to
05ccfbe
Compare
timj
force-pushed
the
tickets/DM-25972
branch
from
cecbc0f to
b8c6c1a
Compare
Requires pymysql, MariaDB, and testing.mysqld. The `replace` tests all fail. There are some major adjustments of column sizes in butler_attributes to make it fit.
testCollections still fails.
timj
force-pushed
the
tickets/DM-25972
branch
from
b8c6c1a to
b761109
Compare
Codecov Report
@@ Coverage Diff @@
## main #334 +/- ##
==========================================
- Coverage 84.14% 84.02% -0.12%
==========================================
Files 237 239 +2
Lines 30305 30417 +112
Branches 5008 5020 +12
==========================================
+ Hits 25499 25558 +59
- Misses 3661 3713 +52
- Partials 1145 1146 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing works but might be useful to build off.