DM-45856: Add new verification pipelines for IsrTaskLSST to _ingredients. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czwa
approved these changes
Sep 19, 2024
| connections.outputExposure: "verifyBiasIsrExp" | ||
| connections.outputBin1Exposure: "verifyBiasIsrExpBin8" | ||
| connections.outputBin2Exposure: "verifyBiasIsrExpBin64" | ||
| doBias: true |
There was a problem hiding this comment.
Same ordering comment as on cp_pipe. As-applied would be my preference, but alphabetical at least makes it faster to find a particular option.
| doFlat: true | ||
| doDiffNonLinearCorrection: false | ||
| doBootstrap: false | ||
| # TODO: Add deferred charge and brighter-fatter pipelines |
| doVariance: true | ||
| doSaturation: false | ||
| doSuspect: false | ||
| doCrosstalk: true |
There was a problem hiding this comment.
Does this need the quadratic crosstalk terms enabled? I think those are disabled by default.
erykoff
force-pushed
the
tickets/DM-45856
branch
from
823711e
to
17110a0
Compare
Note that this pipeline needs work/testing in DM-46445.
erykoff
force-pushed
the
tickets/DM-45856
branch
from
a9224b2
to
ca46a41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.