Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-46356: Update testing to use new IsrTaskLSST calibration pipeline #41

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

DM-46356: Update testing to use new IsrTaskLSST calibration pipeline #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c1cd27e
Move legacy LATISS specific ci_cpp_gen3 pipelines to LATISS/legacy_20…
erykoff Sep 18, 2024
47b97a5
Move legacy LATISS tests in SConscript, to be activated with env var.
erykoff Sep 18, 2024
3bf89d2
Update legacy tests to run with CI_CPP_LEGACY env var set to 1.
erykoff Sep 18, 2024
203918d
Move legacy test comparison yamls to legacy directory.
erykoff Sep 18, 2024
db00be0
Add new IsrTaskLSST based pipelines to SConscript.
erykoff Sep 18, 2024
b0a3d48
Update test code to support new IsrTaskLSST outputs.
erykoff Sep 18, 2024
95c11b1
Update test verification README for (previously) updated file locations.
erykoff Sep 18, 2024
89e9eec
Add local science run pipeline for IsrTaskLSST.
erykoff Sep 18, 2024
7c4374b
Add test verification yamls for new IsrTaskLSST pipelines.
erykoff Sep 18, 2024
e79b1bb
Use instrument-specific directory for local pipelines.
erykoff Sep 21, 2024
56b438f
Add appropriate TODOs for full ISR pipeline.
erykoff Sep 23, 2024
d76fe19
Add running of BFK generation pipeline.
erykoff Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
916 changes: 665 additions & 251 deletions DATA/SConscript
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion pipelines/cpCrosstalk.yaml → ...nes/LATISS/legacy_202409/cpCrosstalk.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
description: ci_cpp CROSSTALK calibration construction
instrument: lsst.obs.lsst.Latiss
imports:
- location: $CP_PIPE_DIR/pipelines/LATISS/cpCrosstalk.yaml
- location: $CP_PIPE_DIR/pipelines/LATISS/legacy_202409/cpCrosstalk.yaml
tasks:
cpCrosstalkSolve:
class: lsst.cp.pipe.CrosstalkSolveTask
Expand Down
2 changes: 1 addition & 1 deletion pipelines/cpCti.yaml → pipelines/LATISS/legacy_202409/cpCti.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
description: cp_pipe CTI calibration construction -- for ci_cpp only!
instrument: lsst.obs.lsst.Latiss
imports:
- location: $CP_PIPE_DIR/pipelines/LATISS/cpCti.yaml
- location: $CP_PIPE_DIR/pipelines/LATISS/legacy_202409/cpCti.yaml
tasks:
cpCtiSolve:
class: lsst.cp.pipe.CpCtiSolveTask
Expand Down
0 pipelines/runCti.yaml → pipelines/LATISS/legacy_202409/runCti.yaml
View file
Open in desktop
File renamed without changes.
0 pipelines/runIsr.yaml → pipelines/LATISS/legacy_202409/runIsr.yaml
View file
Open in desktop
File renamed without changes.
11 changes: 11 additions & 0 deletions pipelines/LATISS/runIsrLSST.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
description: ip_isr for ci_cpp_gen3
instrument: lsst.obs.lsst.Latiss
tasks:
isr:
class: lsst.ip.isr.IsrTaskLSST
config:
# TODO DM-46445: Configure BFK generation from test data so
# that this gives reasonable results.
doBrighterFatter: false
# TODO DM-46426: Add cpCtiLSST pipeline so that this can be True.
doDeferredCharge: false
6 changes: 3 additions & 3 deletions tests/data/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ Run level:

.. code-block:: sh

cp ../../DATA/ci_cpv_flat/*/verifyFlatStats/verifyFlatStats* ./flatRun.yaml
cp ../../DATA/ci_cpv_flat/*/verifyFlatStats/r/RG610~empty/* ./flatRun.yaml

Exposure level:

Expand All @@ -116,13 +116,13 @@ Run level:

.. code-block:: sh

cp ../../DATA/ci_cpv_linearizer/*/verifyLinearityStats/verifyLinearityStats* ./linearityRun.yaml
cp ../../DATA/ci_cpv_linearizer/*/verifyLinearizerStats/verifyLinearizerStats* ./linearizerRun.yaml

Detector level:

.. code-block:: sh

cp ../../DATA/ci_cpv_linearizer/*/verifyLinearityDetStats/verifyLinearityDetStats* ./linearityDet.yaml
cp ../../DATA/ci_cpv_linearizer/*/verifyLinearizerDetStats/verifyLinearizerDetStats* ./linearizerDet.yaml


ptc
Expand Down
Loading
Loading