Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tickets/dm 47890: Support Summit Observing Weeks 49-50 of 2024 #255

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

edennihy
Copy link
Contributor

No description provided.

…k method to use new m1m3_in_engineering_mode context manager to enter/exit engineering mode when setting slew controller settings.
Copy link
Contributor

@dsanmartim dsanmartim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. I just added two small comments in the news fragments for your consideration.

@@ -0,0 +1 @@
In maintel/m1m3/enable_m1m3_slew_controller_flags.py, update run_block method to use new m1m3_in_engineering_mode context manager to enter/exit engineering mode when setting slew controller settings.
Copy link
Contributor

@dsanmartim dsanmartim Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just add code quotes:

  • maintel/m1m3/enable_m1m3_slew_controller_flags.py --> maintel/m1m3/enable_m1m3_slew_controller_flags.py

  • run_block --> run_block

  • m1m3_in_engineering_mode --> m1m3_in_engineering_mode

@@ -0,0 +1 @@
In auxtel/daytime_checkout/slew_and_take_image_checkout.py, fix how TCS readiness is configured.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auxtel/daytime_checkout/slew_and_take_image_checkout.py --> auxtel/daytime_checkout/slew_and_take_image_checkout.py

@edennihy edennihy merged commit ab8b5db into develop Dec 17, 2024
2 checks passed
@edennihy edennihy deleted the tickets/DM-47890 branch December 17, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants