Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tickets/DM-48018: Script for balanced AOS triplets. #253

Closed
wants to merge 11 commits into from

Conversation

jfcrenshaw
Copy link

@jfcrenshaw jfcrenshaw commented Dec 7, 2024

This enables taking AOS triplets while splitting dz offsets equally between the camera and M2 hexapods. This allows us to generate the equivalent defocus without simultaneously generating spherical aberration.

The new files subclass the original take_aos_sequence equivalents with the following small changes:

  • New script is called take_aos_sequence_balanced_comcam.py
  • New class is named TakeAOSSequenceBalancedComCam
  • Code to set offsets is now:
await self.mtcs.offset_camera_hexapod(x=0, y=0, z=z_offset / 2, u=0, v=0)
await self.mtcs.offset_m2_hexapod(x=0, y=0, z=z_offset / 2, u=0, v=0)

Small changes were made to the original to reduce code-duplication for the subclasses.

@jfcrenshaw jfcrenshaw changed the title Script for balanced AOS triplets. tickets/DM-48018: Script for balanced AOS triplets. Dec 7, 2024
@jfcrenshaw jfcrenshaw requested a review from gmegh December 7, 2024 22:34
@jfcrenshaw
Copy link
Author

Sorry for not being better about linting and formatting before commits. I will squash these if this gets merged.

@jfcrenshaw jfcrenshaw closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants