tickets/DM-46980: Add home dome SAL script for MT #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribeiro
reviewed
Nov 5, 2024
|
|
||
| if self.mtcs is None: | ||
| self.mtcs = MTCS( | ||
| domain=self.domain, intended_usage=MTCSUsages.Slew, log=self.log |
There was a problem hiding this comment.
I think you will also need the StateTransition usage.
intended_usage=MTCSUsages.Slew | MTCSUsages.StateTransition
| metadata.duration = self.home_dome_duration | ||
|
|
||
| async def run(self): | ||
| await self.mtcs.enable() |
There was a problem hiding this comment.
It is probably not a good idea to call enable here.. they should have all components enabled or the script should fail.
cvillalon
force-pushed
the
tickets/DM-46980
branch
from
b7c3b40 to
cbb4c86
Compare
cvillalon
force-pushed
the
tickets/DM-46980
branch
from
cbb4c86 to
97c593b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.