Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update take_aos_sequence_comcam.py to use ComCam instead of ComCamSim. #235

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Update take_aos_sequence_comcam.py to use ComCam instead of ComCamSim. #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8022763
Update `take_aos_sequence_comcam.py` to use ComCam instead of ComCamSim.
gmegh Oct 21, 2024
048045c
Fix take_aos_sequence so intra-focal focus Z is negative and extra is…
gmegh Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/news/DM-47007.perf.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Update `take_aos_sequence_comcam.py` to use ComCam instead of ComCamSim.
6 changes: 3 additions & 3 deletions python/lsst/ts/standardscripts/maintel/take_aos_sequence_comcam.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ async def take_aos_sequence(self) -> None:
self.log.debug("Moving to intra-focal position")

# Move the hexapod to the target z position
z_offset = self.dz - self.current_z_position
z_offset = -self.dz - self.current_z_position
await self.mtcs.offset_camera_hexapod(x=0, y=0, z=z_offset, u=0, v=0)
self.current_z_position = self.dz

Expand All @@ -269,7 +269,7 @@ async def take_aos_sequence(self) -> None:
self.log.debug("Moving to extra-focal position")

# Move the hexapod to the target z position
z_offset = -self.dz - self.current_z_position
z_offset = self.dz - self.current_z_position
await self.mtcs.offset_camera_hexapod(x=0, y=0, z=z_offset, u=0, v=0)
self.current_z_position = -self.dz

Expand All @@ -288,7 +288,7 @@ async def take_aos_sequence(self) -> None:
if self.mode == Mode.TRIPLET:
self.log.info("Send processing request to RA OCPS.")
config = {
"LSSTComCamSim-FROM-OCS_DONUTPAIR": f"{intra_visit_id[0]},{extra_visit_id[0]}"
"LSSTComCam-FROM-OCS_DONUTPAIR": f"{intra_visit_id[0]},{extra_visit_id[0]}"
}
ocps_execute_task = asyncio.create_task(
self.ocps.cmd_execute.set_start(
Expand Down
Loading