Tickets/DM-45823: Establish um as the unit for hexapod offsets in BaseFocusSweep and implement conversion to mm for auxtel in FocusSweepLatiss #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plement conversion to mm for auxtel in FocusSweepLatiss - The `focus_window` and `focus_step_sequence` attributes of `BaseFocusSweep` are measured in um. - A conversion to mm has been added for `focus_window` and `focus_step_sequence` in the configure method of `FocusSweepLatiss`. - No conversion is needed for maintel, as um is the expected unit for hexapod offsets.
tribeiro
approved these changes
Oct 18, 2024
| Script configuration, as defined by `schema`. | ||
| """ | ||
| await super().configure(config=config) | ||
| self.log.debug("Applying unit translation from um to mm for ATHexapod use.") |
There was a problem hiding this comment.
Please, merge these 3 debug calls together... In our system, calls to log will be sent to the control system and stored in the EFD. Having 3 consecutive calls to log is way more expensive than having only one. Also, note that you can use multiline string to format the text, and make it an f-string, e.g.:
self.log.debug(f"""Applying unit conversion from um to mm for ATHexapod use.
Original values in um from base class configuration are:
focus_window = {self.config.focus_window} um
focus_step_sequence = {self.config.focus_step_sequence} um
Converted values:
focus_window = {self.config.focus_window} mm
focus_step_sequence = {self.config.focus_step_sequence} mm
"""
)
Note that I replaced "translation" with "conversion" above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.