Tickets/DM-46864: Take AOS Sequence

[gmegh]

No description provided.

[tribeiro]

Consider creating an enumeration to hold the valid values for the mode.

Then you can compare enum values instead of strings, which will make it more readable and easy to update.

you could have something like:

class Mode(enum.IntEnum):
    TRIPLET = enum.auto()
    INTRA = enum.auto()
    EXTRA = enum.auto()

Then in the configuration you could do something like this.

schema_yaml = f"""
...
              mode:
                description: >-
                    Mode of operation. Options are 'triplet' (default), 'intra' or 'extra'.
                type: str
                default: 'triplet'
                enum: {[mode for mode in Mode]}

Then, you will have to covert the value to a mode enum:

self.mode = getattr(Mode, config.mode)

and then compare mode to the enum values instead of strings, e.g:

if self.mode == Mode.TRIPLET or self.mode == Mode.INTRA:
    ...

[tribeiro]

Should be

number_of_images = 3 if self.mode == Mode.TRIPLET else 2

[tribeiro]

Maybe take_aos_sequence?

[tribeiro]

I don't see the value of having this method here. Why not just call self.camera.take_cwfs directly? note that, because this is a method, you need to add self.supplemented_group_id as a class attribute. I suggest you get rid of this method (and also remove self.supplemented_group_id in favor of a local variable. If you really want to have a method to encapsulate this operation (it does make the inline call leaner), pass supplemented_group_id alongside reason_suffix instead of relying on a class attribute.

[tribeiro]

Please, replace "out-of-focus" with "aos".