Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tickets/dm-47795 #181

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Tickets/dm-47795 #181

wants to merge 2 commits into from

Conversation

kfanning
Copy link
Member

Fixing OBS-708 - m1m3/check_actuators.py exits M1M3 engineering mode before the secondary test of the last actuator if the primary fails. This change causes mtcs._wait_bump_test_ok to wait for both tests to finish before raising a RuntimeError in the case one fails.

…void prematurely raising a RuntimeError when testing both primary and secondary when the first one tested fails.
@kfanning kfanning requested a review from tribeiro November 26, 2024 00:11
Copy link
Member

@tribeiro tribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand what is going on here. Can you please clarify what it is you are trying to fix?

There's no description in the ticket of what you are trying to fix and the context here does not allow me to understand the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants