Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-47414: In base_camera.py, remove support for splitting guider ROI … #176

Merged
merged 2 commits into from
Dec 18, 2024
Merged

DM-47414: In base_camera.py, remove support for splitting guider ROI … #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e24300
DM-47414: In base_camera.py, remove support for splitting guider ROI …
kfanning Nov 6, 2024
f10e809
DM-47414: remove test long guider ROI as there is no longer a fork in…
kfanning Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/news/DM-47414.removal.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
In base_camera.py, remove support for splitting guider ROI specs into multiple part. Size limit no longer exists.
1 change: 0 additions & 1 deletion python/lsst/ts/observatory/control/base_camera.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1148,7 +1148,6 @@ async def init_guider(self, roi_spec: ROISpec) -> None:
roi = roi_spec_dict.pop("roi")
roi_spec_dict.update(roi)
roi_spec_json = json.dumps(roi_spec_dict, separators=(",", ":"))
self.log.info(f"ROISpec(len:{len(roi_spec_json)}) fits in one command.")
await self.camera.cmd_initGuiders.set_start(
roiSpec=roi_spec_json,
timeout=self.long_timeout,
Expand Down
7 changes: 6 additions & 1 deletion tests/maintel/test_lsstcam.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,12 @@ async def test_init_guider(self) -> None:

roi_spec = ROISpec(
common=roi_common,
roi=dict(R40_SG0=roi),
roi=dict(
R40_SG0=roi,
R01_SG0=roi,
R02_SG0=roi,
R03_SG0=roi,
),
)

# initialize guiders
Expand Down
Loading