-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-49481: Add projector Electrometer to ts_config_ocs #386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of issues to fix. Remember that the TTS and BTS are distinct services and don't and shouldn't match values at the summit.
Electrometer/v7/_base.yaml
Outdated
@@ -6,10 +6,10 @@ instances: | |||
mode: 1 | |||
range: 2.0e-08 | |||
tcpip: | |||
hostname: 'localhost' | |||
hostname: 'cbp-calElectrometer.cp.lsst.org' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for the base test stand, please leave as localhost.
Electrometer/v7/_base.yaml
Outdated
port: 5024 | ||
timeout: 2 | ||
s3_instance: "ls" | ||
s3_instance: "cp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also for the base test stand please leave as ls.
Electrometer/v7/_base.yaml
Outdated
@@ -32,10 +32,10 @@ instances: | |||
mode: 1 | |||
range: 2.0e-08 | |||
tcpip: | |||
hostname: 'localhost' | |||
hostname: 'cbp-Electrometer.cp.lsst.org' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leave as localhost.
Electrometer/v7/_base.yaml
Outdated
port: 5024 | ||
timeout: 2 | ||
s3_instance: "ls" | ||
s3_instance: "cp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leave as ls.
Electrometer/v7/_base.yaml
Outdated
mode: 1 | ||
range: 2.0e-08 | ||
tcpip: | ||
hostname: 'flatfield-stages.cp.lsst.org' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be localhost.
Electrometer/v7/_tucson.yaml
Outdated
@@ -36,7 +37,7 @@ instances: | |||
timeout: 2 | |||
s3_instance: "cp" | |||
fits_file_path: '/home/saluser/develop/electrometerFitsFiles' | |||
image_name_service: "http://comcam-mcm.tu.lsst.org" | |||
image_name_service: "http://ccs.lsst.org" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leave as is for TTS.
Electrometer/v7/_tucson.yaml
Outdated
hostname: 'flatfield-stages.cp.lsst.org' | ||
port: 4002 | ||
timeout: 2 | ||
s3_instance: "cp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use tu.
Electrometer/v7/_tucson.yaml
Outdated
timeout: 2 | ||
s3_instance: "cp" | ||
fits_file_path: '/home/saluser/develop/electrometerFitsFiles' | ||
image_name_service: "http://ccs.lsst.org" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use comcam-mcm.tu.lsst.org
Electrometer/v7/_tucson.yaml
Outdated
@@ -62,7 +89,7 @@ instances: | |||
timeout: 2 | |||
s3_instance: "cp" | |||
fits_file_path: '/home/saluser/develop/electrometerFitsFiles' | |||
image_name_service: "http://comcam-mcm.tu.lsst.org" | |||
image_name_service: "http://ccs.lsst.org" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leave as it was for TTS.
Electrometer/v7/_tucson.yaml
Outdated
electrometer_config: {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a blank line at the end of the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still a couple of changes to address.
Electrometer/v7/_summit.yaml
Outdated
electrometer_config: {} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line has whitespace in it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Make sure to squash commits.
e8f83f8
to
70a2b19
Compare
This is the Keithley electrometer in the projector, connected to a Moxa device. The index should be 103.