Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-49481: Add projector Electrometer to ts_config_ocs #386

Merged
merged 2 commits into from
Mar 16, 2025

Conversation

parfa30
Copy link
Contributor

@parfa30 parfa30 commented Mar 14, 2025

This is the Keithley electrometer in the projector, connected to a Moxa device. The index should be 103.

@parfa30 parfa30 requested a review from a team as a code owner March 14, 2025 12:54
Copy link
Contributor

@couger01 couger01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of issues to fix. Remember that the TTS and BTS are distinct services and don't and shouldn't match values at the summit.

@@ -6,10 +6,10 @@ instances:
mode: 1
range: 2.0e-08
tcpip:
hostname: 'localhost'
hostname: 'cbp-calElectrometer.cp.lsst.org'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for the base test stand, please leave as localhost.

port: 5024
timeout: 2
s3_instance: "ls"
s3_instance: "cp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also for the base test stand please leave as ls.

@@ -32,10 +32,10 @@ instances:
mode: 1
range: 2.0e-08
tcpip:
hostname: 'localhost'
hostname: 'cbp-Electrometer.cp.lsst.org'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave as localhost.

port: 5024
timeout: 2
s3_instance: "ls"
s3_instance: "cp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave as ls.

mode: 1
range: 2.0e-08
tcpip:
hostname: 'flatfield-stages.cp.lsst.org'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be localhost.

@@ -36,7 +37,7 @@ instances:
timeout: 2
s3_instance: "cp"
fits_file_path: '/home/saluser/develop/electrometerFitsFiles'
image_name_service: "http://comcam-mcm.tu.lsst.org"
image_name_service: "http://ccs.lsst.org"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave as is for TTS.

hostname: 'flatfield-stages.cp.lsst.org'
port: 4002
timeout: 2
s3_instance: "cp"
Copy link
Contributor

@couger01 couger01 Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use tu.

timeout: 2
s3_instance: "cp"
fits_file_path: '/home/saluser/develop/electrometerFitsFiles'
image_name_service: "http://ccs.lsst.org"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use comcam-mcm.tu.lsst.org

@@ -62,7 +89,7 @@ instances:
timeout: 2
s3_instance: "cp"
fits_file_path: '/home/saluser/develop/electrometerFitsFiles'
image_name_service: "http://comcam-mcm.tu.lsst.org"
image_name_service: "http://ccs.lsst.org"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave as it was for TTS.

electrometer_config: {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a blank line at the end of the file.

Copy link
Contributor

@couger01 couger01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a couple of changes to address.

electrometer_config: {}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line has whitespace in it.

Copy link
Contributor

@couger01 couger01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Make sure to squash commits.

@parfa30 parfa30 merged commit 9c362b6 into develop Mar 16, 2025
1 check passed
@parfa30 parfa30 deleted the tickets/DM-49481 branch March 16, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants