Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MTScheduler: Add BLOCK-T345 json for science program #367

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

MTScheduler: Add BLOCK-T345 json for science program #367

wants to merge 3 commits into from
+320 −0

Conversation

gmegh
Copy link
Contributor

@gmegh gmegh commented Dec 9, 2024

No description provided.

@gmegh gmegh requested a review from a team as a code owner December 9, 2024 19:00
dsanmartim
dsanmartim approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@dsanmartim dsanmartim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added a comment. Apart from that, everything else looks good to me.

Scheduler/observing_blocks_maintel/AOS/BLOCK-T345.json Show resolved Hide resolved
tribeiro
tribeiro reviewed Dec 9, 2024
View reviewed changes
Copy link
Member

@tribeiro tribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good, but please, fix the startup_database and the observation_database_name.

Scheduler/observing_blocks_maintel/AOS/BLOCK-T345.json Show resolved Hide resolved
Scheduler/v7/maintel_fbs_sit_block_t345.yaml Outdated Show resolved Hide resolved
Scheduler/v7/maintel_fbs_sit_block_t345.yaml Outdated Show resolved Hide resolved
tribeiro
tribeiro requested changes Dec 9, 2024
View reviewed changes
Copy link
Member

@tribeiro tribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am just going to block the PR until we have tested it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhiannonlynne rhiannonlynne rhiannonlynne left review comments

@tribeiro tribeiro tribeiro requested changes

@dsanmartim dsanmartim dsanmartim approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gmegh @rhiannonlynne @tribeiro @dsanmartim