Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configurable focus sweep block #286

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add configurable focus sweep block #286

wants to merge 1 commit into from

Conversation

jmeyers314
Copy link
Contributor

No description provided.

@jmeyers314 jmeyers314 force-pushed the u/jmeyers3/parameterizable_focus_sweep branch from 4c45b90 to 3c372eb Compare July 18, 2024 21:02
@jmeyers314 jmeyers314 marked this pull request as ready for review July 18, 2024 21:02
tribeiro
tribeiro requested changes Aug 12, 2024
View reviewed changes
Copy link
Member

@tribeiro tribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, rebase this to develop.

Also, we need to find a place for that python script.

Scheduler/observing_blocks_ocs/process_schema.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove this python script. If you think this is needed, we should move it to a more appropriate repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tribeiro tribeiro tribeiro requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmeyers314 @tribeiro