Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial addition of reflector #23

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Initial addition of reflector #23

wants to merge 3 commits into from

Conversation

JosephParsons
Copy link
Contributor

No description provided.

@JosephParsons JosephParsons self-assigned this Jun 7, 2024
@JosephParsons JosephParsons requested a review from couger01 June 13, 2024 14:26
couger01
couger01 previously requested changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@couger01 couger01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the MTReflector configuration needs to have the real production values even if they are not well known yet.

MTReflector/v1/_init.yaml Show resolved Hide resolved
MTReflector/v1/_summit.yaml Show resolved Hide resolved
MTReflector/v1/_tucson.yaml Show resolved Hide resolved
towncrier.toml Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an empty line at the end of this file.

@parfa30 parfa30 requested a review from couger01 November 4, 2024 20:00
@couger01 couger01 requested a review from wvreeven November 5, 2024 18:12
wvreeven
wvreeven approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@wvreeven wvreeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@couger01 couger01 dismissed their stale review November 6, 2024 12:19

I'm working on this now.

@couger01 couger01 removed their request for review November 6, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wvreeven wvreeven wvreeven approved these changes

@couger01 couger01 couger01 left review comments

Assignees

@JosephParsons JosephParsons

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JosephParsons @wvreeven @couger01 @parfa30