SITCOM-1786: Add CountRows command #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fred3m
requested changes
Dec 19, 2024
There was a problem hiding this comment.
See my comments in the other PR regarding making a more general aggregate command that can be used to run arbitrary aggregate functions.
It could also be useful to modify the code that fetches columns from the server to first check for the number of rows and if that number is greater than some amount (maybe 100k?) prompting the user to ask if they want to continue. That could either be part of this ticket or a new ticket, but once we get on sky with LsstCam I think that it will be a necessary feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.