-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTPtg Configuration - tickets/SITCOM-1431 #129
base: main
Are you sure you want to change the base?
Conversation
665dac3
to
c0e61be
Compare
c0e61be
to
e1a7ab1
Compare
e1a7ab1
to
810cde6
Compare
…Images add to the _static folder. firts document iteration
896d878
to
d5dfd6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Paulina, great job with this document.
As this is a procedure it should use the procedure template.
You need to update the changes made in the Confluence version of this document, I added 2 comments in Confluence.
Most comments are suggestions to rewrite some parts, feel free to ignore them.
Thanks!
|
||
3. Connect to the ``MTPtg`` **pod mtptg-djhjv** within the *<namespace>* maintel. | ||
|
||
The command will open a terminal within the pod. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this refer to the command below? if so, consider changing 'The command..' to 'The command below' or 'This command'
|
||
.. | ||
|
||
4. **Move to configuration directory,** the configuration files are one level up. The directory contains the configuration files :file:`MTPtg.info` (:file:`ATPtg.info` for AuxTel) and the pointing models :file:`mt.mod` files (:file:`at.mod` for AuxTel). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid confusion, we may want to exclude the AuxTel files.
.. _MTMTPtg-Configuration-for-MTRotator-and-MTMount: | ||
|
||
############################################# | ||
MTPtg Configuration for MTRotator and MTMount |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is a procedure it should have the corresponding template
Error Diagnosis | ||
=============== | ||
|
||
Cases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part maybe should be in the overview section of the procedure template
|
||
.. warning:: | ||
|
||
Announce through the Slack channel *#summit-simonyi* that the component is not available, and you are about to change the configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this part should be the first step of the procedure, adding a note that it should not be skipped
|
||
4. **Move to configuration directory,** the configuration files are one level up. The directory contains the configuration files :file:`MTPtg.info` (:file:`ATPtg.info` for AuxTel) and the pointing models :file:`mt.mod` files (:file:`at.mod` for AuxTel). | ||
|
||
At startup, the pointing component loads by default the pointing model :file:`mt.mod` file and the :file:`MTPtg.info` (equivalent for AuxTel). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove '(equivalent for AuxTel)' Maybe add a note of the equivalence below the procedure's steps.
|
||
5. To edit the :file:`MTPtg.info` file use a text editor such as *vi*. | ||
|
||
5.1. ``MTRotator``: The **disable_rotator** line of the :file:`MTPtg.info` file contains the parameter you need to change. It reflects whether the ``MTRotator`` is monitored in the tracking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider rewriting as
'Edit the disable_rotator parameter in the MTPtg.info file
- set 1: rotator will be ignored and not be commanded by the MTPtg component (disabled)
- set 0: rotator will be considered (enabled) '
.. | ||
|
||
|
||
5.2. ``MTMount``: The line containing the **disable_mount** parameter in the :file:`MTPtg.info` file is the one to edit. It shows whether the ``MTMount`` is monitored in the tracking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same suggestion as previous point (step 5.1)
|
||
Contingency | ||
=========== | ||
* If the procedure is not successful, report the issue in *#summit-simonyi*, inform the commissioning scientist on duty, and/or activate the xxxxxxOut of Hours Support_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix 'Out of hour support' link
|
||
6. **Exit** the **pod** by typing :command:`exit`. | ||
|
||
7. From LOVE, **send** the ``MTPtg`` back to ``ENABLED`` using the script :file:`set_summary_state.py` and configuration below. ``MTMount`` must be ``ENABLED``, even if not tracking, so ``CCW`` can be still monitored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest rewriting as
'Send the MTPtg to ENABLED using the script set_summary_state.py and configuration below in the MTQueue.
Note: MTMount must be ENABLED, even if not tracking, so CCW can be still monitored.
'
Hi @dsanmartim and @JackieS-NL .
I hope you're doing well. I wanted to kindly ask if you could take some time to review the work I've completed on ticket SITCOM-1431. "MTPtg Configuration for MTRotator and MTMount"
Please let me know if you have any questions
Paulina