DM-47986: Catch errors from initializing Butler in worker #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the backend worker, catch errors from parsing the dataset ID or from initializing Butler. Both can fail due to bad dataset IDs and previously those exceptions weren't being translated into worker exceptions and thus were being reported as uncaught exceptions and generic job failures. Now they will be correctly translated into usage or job failure errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the backend worker, catch errors from parsing the dataset ID or from initializing Butler. Both can fail due to bad dataset IDs and previously those exceptions weren't being translated into worker exceptions and thus were being reported as uncaught exceptions and generic job failures. Now they will be correctly translated into usage or job failure errors.