Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40259: Update storybook to v7 and adopt pnpm #142

Merged
merged 12 commits into from
Aug 1, 2023
Merged

Conversation

jonathansick
Copy link
Member

Two improvements that help prepare us for migrating into a monorepo for Squareone:

  1. Update to Storybook v7. This enables us to continue using chromatic for testing, and also unlocks new features in Storybook.
  2. Adopt pnpm, replacing npm. pnpm has better workspace support, which is useful for working in a monorepo.

With node:16-alpine, pnpm needs to be installed.
I ran the automatic suggested migrations after running the update
command at https://storybook.js.org/docs/react/migration-guide

The only thing that didn't migrate was .storybook/main.js
This replaces the guide in the README and also updates it to reflect
pnpm.
Also link to the development guide now in the docs site.
@jonathansick jonathansick marked this pull request as ready for review August 1, 2023 18:41
@jonathansick jonathansick merged commit fd5c64e into main Aug 1, 2023
5 checks passed
@jonathansick jonathansick deleted the tickets/DM-40259 branch August 1, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant