Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.2.0 #25

Merged
merged 6 commits into from
Aug 7, 2024
Merged

0.2.0 #25

merged 6 commits into from
Aug 7, 2024

Conversation

Fireye04
Copy link
Member

@Fireye04 Fireye04 commented Aug 3, 2024

No description provided.

@Fireye04 Fireye04 requested a review from afausti August 6, 2024 00:46
afausti
afausti approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@afausti afausti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! this refactoring will make it easier to add support to other APIs.

CHANGELOG.md Outdated Show resolved Hide resolved
src/sasquatchbackpack/cli.py Show resolved Hide resolved
@afausti afausti mentioned this pull request Aug 7, 2024
Closed
@afausti
Copy link
Member

afausti commented Aug 7, 2024

LGTM
We could fix issue #24 in this PR before releasing 0.2.0, or merge this one and then open another PR for the fix, whatever you prefer.

afausti
afausti approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@afausti afausti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fireye04 Fireye04 merged commit 3f38a17 into main Aug 7, 2024
12 checks passed
@Fireye04 Fireye04 deleted the 0.2.0 branch August 7, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afausti afausti afausti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fireye04 @afausti