DM-48101: Sentry helpers #366
Merged
+751
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fajpunk
added a commit
to lsst-sqre/mobu
that referenced
this pull request
Jan 15, 2025
* Replace Safir `SlackException` functionality with Sentry error reporting. * Replace `timings` functionality with Sentry tracing. The biggest conceptual change is that instead of putting error details on the exception objects themselves, they get put into the global-per-business-execution Sentry scope, and whatever is in the scope is sent to Sentry when an error occurs (except for a very few cases where we still attach info directly to exceptions). This instruments custom scopes and transactions and fingerprints, which are described in the new `sentry.rst` file in the docs. Finally, this uses some more general Sentry helpers proposed for Safir in lsst-sqre/safir#366.
|
The remaining docs issue is You can fix this by either ignoring the link altogether (see https://documenteer.lsst.io/guides/toml-reference.html#ignore in |
jonathansick
approved these changes
Jan 17, 2025
fajpunk
force-pushed
the
tickets/DM-48101/sentry-helpers
branch
2 times, most recently
from
cbd2812 to
a26f5e4
Compare
jonathansick
approved these changes
Jan 21, 2025
fajpunk
force-pushed
the
tickets/DM-48101/sentry-helpers
branch
from
a26f5e4 to
f5f8025
Compare
fix docs fix linkcheck reorganize docs
fajpunk
force-pushed
the
tickets/DM-48101/sentry-helpers
branch
from
f5f8025 to
eef7e5e
Compare
fajpunk
added a commit
to lsst-sqre/mobu
that referenced
this pull request
Jan 22, 2025
* Replace Safir `SlackException` functionality with Sentry error reporting. * Replace `timings` functionality with Sentry tracing. The biggest conceptual change is that instead of putting error details on the exception objects themselves, they get put into the global-per-business-execution Sentry scope, and whatever is in the scope is sent to Sentry when an error occurs (except for a very few cases where we still attach info directly to exceptions). This instruments custom scopes and transactions and fingerprints, which are described in the new `sentry.rst` file in the docs. Finally, this uses some more general Sentry helpers proposed for Safir in lsst-sqre/safir#366.
fajpunk
added a commit
to lsst-sqre/mobu
that referenced
this pull request
Jan 28, 2025
* Replace Safir `SlackException` functionality with Sentry error reporting. * Replace `timings` functionality with Sentry tracing. The biggest conceptual change is that instead of putting error details on the exception objects themselves, they get put into the global-per-business-execution Sentry scope, and whatever is in the scope is sent to Sentry when an error occurs (except for a very few cases where we still attach info directly to exceptions). This instruments custom scopes and transactions and fingerprints, which are described in the new `sentry.rst` file in the docs. Finally, this uses some more general Sentry helpers proposed for Safir in lsst-sqre/safir#366. docs fix more docs fixes fix bad autocomplete contextlib import move remove_ansi_escape_sequences no need for gafaelfawr user tag Add docstrings Init sentry in create_app split notebook execution into many methods don't shove so much into an fstring nicer self name references separate image_description and image_reference tags remove username from fingerprint transaction refactor variable for business name move tap 'make_client' span into the actual 'make_client' method transaction refactor again update sentry docs put back explicit tap client creation error add tests for sentry transactions changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.