-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-47986: Convert the UWS library to use the Wobbly backend #349
Conversation
95427a0
to
6aae663
Compare
The typing here internally is not great — the parameters type is |
I should also note that I temporarily removed job expiration. I need to think about the right way to handle that between the application and Wobbly and will re-add it in a later PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, and I think it reenforces that making Wobbly was the right thing to do. Some minor things, mostly documentation stuff.
Rather than storing UWS jobs directly in a database, which requires every UWS-based application to manage its own separate database, use the Wobbly service to manage all job storage. This service uses a delegated token to determine the user and service, so considerably less tracking of the user is required. UWS applications now store the serialized parameter model in the database rather than a list of key/value pairs, and rely on methods on the parameters model to convert to the XML format for the current IVOA UWS protocol. Add a mock for Wobbly that can be used to test UWS applications without having the Wobbly API available. Drop the `ErrorCode` enum, since its values were specific to SODA, and instead take the error code as a string. Drop some related exceptions that are not used directly in Safir and are specific to SODA.
6aae663
to
dbc082f
Compare
Rather than storing UWS jobs directly in a database, which requires every UWS-based application to manage its own separate database, use the Wobbly service to manage all job storage. This service uses a delegated token to determine the user and service, so considerably less tracking of the user is required.
UWS applications now store the serialized parameter model in the database rather than a list of key/value pairs, and rely on methods on the parameters model to convert to the XML format for the current IVOA UWS protocol.
Add a mock for Wobbly that can be used to test UWS applications without having the Wobbly API available.
Drop the
ErrorCode
enum, since its values were specific to SODA, and instead take the error code as a string. Drop some related exceptions that are not used directly in Safir and are specific to SODA.