DM-48116: Fix ingress/tls indentation issue with argo-cd values files #3979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rra
approved these changes
Dec 12, 2024
stvoutsin
force-pushed
the
tickets/DM-48116
branch
from
94835e9 to
d69e491
Compare
|
One more changed made, fixed typo in ccin2p3 argocd values file. |
stvoutsin
force-pushed
the
tickets/DM-48116
branch
from
d69e491 to
0b3e1ab
Compare
stvoutsin
force-pushed
the
tickets/DM-48116
branch
from
0b3e1ab to
3a33fee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was an indentation issue which showed up recently at the roe environment when they tried to synchronize. The symptoms were that argo-cd failed to synchronize, with error referring to
letsencypt-dns. Upon further investigation it seems that thetls: falsewas missplaced, and should be underingressrather thanserver.This PR addresses the issue by fixing the indentation to match the expected nesting of the ingress setting.
How was this tested
Tested on the ROE environments (test & prod) and it works, they can now synchronize argo-cd successfully