DM-44635: mobu: nicer config #3509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fajpunk
force-pushed
the
tickets/DM-44635/mobu-nicer-config
branch
from
0b20e6e
to
29d9fb3
Compare
fajpunk
commented
Jul 11, 2024
Comment on lines
-1
to
-3
| config: | ||
| # Mobu here is behind a VPN and is not reachable by github.com | ||
| githubIntegration: false |
There was a problem hiding this comment.
All GitHub integration is disabled by default.
fajpunk
commented
Jul 11, 2024
Comment on lines
-1
to
-3
| config: | ||
| # Mobu here is behind a VPN and is not reachable by github.com | ||
| githubIntegration: false |
There was a problem hiding this comment.
All GitHub integration is disabled by default.
rra
approved these changes
Jul 11, 2024
fajpunk
force-pushed
the
tickets/DM-44635/mobu-nicer-config
branch
4 times, most recently
from
681d382
to
811a166
Compare
* Separate config dicts in Values * Separate anonymous ingresses for each app * Separate ConfigMaps for each app
fajpunk
force-pushed
the
tickets/DM-44635/mobu-nicer-config
branch
from
811a166
to
2d066c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitHub CI app and Refresh app functionality are now completely separated. They each have their own:
Having separate config dicts and ingresses makes it a bit more clear in Phalanx that these are independently toggle-able functionalities, and having config come from completely separate ConfigMaps makes the logic to toggle them in the Mobu app much cleaner.
The mobu changes are in lsst-sqre/mobu#354.