Merge pull request #3903 from lsst-sqre/tickets/DM-47656

DM-47656: Re-enable retries in Prompt Processing fan-out service

applications/next-visit-fan-out/README.md

@@ -22,6 +22,7 @@ Poll next visit events from Kafka, duplicate them, and send them to all applicat
 | kafka.saslMechamism | string | `"SCRAM-SHA-512"` |  |
 | kafka.securityProtocol | string | `"SASL_PLAINTEXT"` |  |
 | knative.maxMessages | string | None, must be set. | The maximum number of messages that can be forwarded to all Knative instances combined. |
+| knative.retryRequests | bool | `true` | Whether or not to retry requests that returned a suitable response. |
 | knative.urls | object | See `values.yaml`. | A mapping of instrument to that instrument's Knative service. |
 | nameOverride | string | `""` |  |
 | nodeSelector | object | `{}` | Node selection rules for the next-visit-fan-out deployment pod |

applications/next-visit-fan-out/templates/deployment.yaml

@@ -41,6 +41,8 @@ spec:
               value: {{ .Values.kafka.securityProtocol }}
             - name: MAX_FAN_OUT_MESSAGES
               value: {{ .Values.knative.maxMessages | toString | quote }}
+            - name: RETRY_KNATIVE_REQUESTS
+              value: {{ ternary "true" "false" .Values.knative.retryRequests | quote }}
             - name: SASL_USERNAME
               valueFrom:
                 secretKeyRef:
@@ -52,7 +54,7 @@ spec:
                   key: kafka_pp_sasl_password
                   name: {{ template "next-visit-fan-out.fullname" . }}-secret
             - name: DEBUG_LOGS
-              value: {{ ternary "true" "false" .Values.debug | quote}}
+              value: {{ ternary "true" "false" .Values.debug | quote }}
             - name: SUPPORTED_INSTRUMENTS
               value: {{ .Values.instruments }}
             - name: INSTRUMENT_CONFIG_FILE

applications/next-visit-fan-out/values-usdfdev-prompt-processing.yaml

@@ -1,5 +1,6 @@
 knative:
   maxMessages: 150
+  retryRequests: false
 
 kafka:
   schemaRegistryUrl: http://10.96.181.159:8081

applications/next-visit-fan-out/values.yaml

@@ -10,6 +10,8 @@ knative:
   # -- The maximum number of messages that can be forwarded to all Knative instances combined.
   # @default -- None, must be set.
   maxMessages: ""
+  # -- Whether or not to retry requests that returned a suitable response.
+  retryRequests: true
 
 kafka:
   offset: latest