Skip to content

Commit

Permalink
Merge pull request #2604 from lsst-sqre/u/rra/resource-limits
Browse files Browse the repository at this point in the history
Specify Kubernetes memory limits in powers of two
  • Loading branch information
rra authored Sep 29, 2023
2 parents 5705e4a + 10bd2a6 commit 675bb08
Show file tree
Hide file tree
Showing 11 changed files with 20 additions and 50 deletions.
4 changes: 2 additions & 2 deletions applications/sherlock/values-base.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
resources:
requests:
cpu: 2.0
memory: "2G"
memory: "2Gi"
limits:
cpu: 4.0
memory: "4G"
memory: "4Gi"
4 changes: 2 additions & 2 deletions applications/sherlock/values-idfdev.yaml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
resources:
requests:
cpu: 2.0
memory: "2G"
memory: "2Gi"
limits:
cpu: 4.0
memory: "4G"
memory: "4Gi"

publishUrl: "https://status.lsst.codes/api/data-dev"
4 changes: 2 additions & 2 deletions applications/sherlock/values-idfint.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
resources:
requests:
cpu: 2.0
memory: "2G"
memory: "2Gi"
limits:
cpu: 4.0
memory: "4G"
memory: "4Gi"
publishUrl: "https://status.lsst.codes/api/data-int"
4 changes: 2 additions & 2 deletions applications/sherlock/values-idfprod.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
resources:
requests:
cpu: 2.0
memory: "2G"
memory: "2Gi"
limits:
cpu: 4.0
memory: "4G"
memory: "4Gi"
publishUrl: "https://status.lsst.codes/api/data"
4 changes: 2 additions & 2 deletions applications/sherlock/values-roe.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
resources:
requests:
cpu: 2.0
memory: "2G"
memory: "2Gi"
limits:
cpu: 4.0
memory: "4G"
memory: "4Gi"
4 changes: 2 additions & 2 deletions applications/sherlock/values-summit.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
resources:
requests:
cpu: 2.0
memory: "2G"
memory: "2Gi"
limits:
cpu: 4.0
memory: "4G"
memory: "4Gi"
4 changes: 2 additions & 2 deletions applications/sherlock/values-tucson-teststand.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
resources:
requests:
cpu: 2.0
memory: "2G"
memory: "2Gi"
limits:
cpu: 4.0
memory: "4G"
memory: "4Gi"
29 changes: 0 additions & 29 deletions applications/tap/values-minikube.yaml

This file was deleted.

4 changes: 2 additions & 2 deletions charts/cadc-tap/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ IVOA TAP service
| nodeSelector | object | `{}` | Node selector rules for the TAP pod |
| podAnnotations | object | `{}` | Annotations for the TAP pod |
| replicaCount | int | `1` | Number of pods to start |
| resources | object | `{"limits":{"cpu":8,"memory":"32G"},"requests":{"cpu":2,"memory":"2G"}}` | Resource limits and requests for the TAP pod |
| resources | object | `{"limits":{"cpu":8,"memory":"32Gi"},"requests":{"cpu":2,"memory":"2Gi"}}` | Resource limits and requests for the TAP pod |
| tapSchema.affinity | object | `{}` | Affinity rules for the TAP schema database pod |
| tapSchema.image.pullPolicy | string | `"IfNotPresent"` | Pull policy for the TAP schema image |
| tapSchema.image.repository | string | `"lsstsqre/tap-schema-mock"` | TAP schema image to ue. This must be overridden by each environment with the TAP schema for that environment. |
Expand All @@ -68,6 +68,6 @@ IVOA TAP service
| uws.image.tag | string | Version of QServ TAP image | Tag of UWS database image to use |
| uws.nodeSelector | object | `{}` | Node selection rules for the UWS database pod |
| uws.podAnnotations | object | `{}` | Annotations for the UWS databse pod |
| uws.resources | object | `{"limits":{"cpu":2,"memory":"4G"},"requests":{"cpu":0.25,"memory":"1G"}}` | Resource limits and requests for the UWS database pod |
| uws.resources | object | `{"limits":{"cpu":2,"memory":"4Gi"},"requests":{"cpu":0.25,"memory":"1Gi"}}` | Resource limits and requests for the UWS database pod |
| uws.tolerations | list | `[]` | Tolerations for the UWS database pod |
| vaultSecretsPath | string | None, must be set | Path to the Vault secret (`secret/k8s_operator/<host>/tap`, for example) |
8 changes: 4 additions & 4 deletions charts/cadc-tap/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ ingress:
resources:
requests:
cpu: 2.0
memory: "2G"
memory: "2Gi"
limits:
cpu: 8.0
memory: "32G"
memory: "32Gi"

# -- Annotations for the TAP pod
podAnnotations: {}
Expand Down Expand Up @@ -198,10 +198,10 @@ uws:
resources:
requests:
cpu: 0.25
memory: "1G"
memory: "1Gi"
limits:
cpu: 2.0
memory: "4G"
memory: "4Gi"

# -- Annotations for the UWS databse pod
podAnnotations: {}
Expand Down
1 change: 0 additions & 1 deletion environments/values-minikube.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,3 @@ applications:
mobu: true
postgres: true
squareone: true
tap: true

0 comments on commit 675bb08

Please sign in to comment.