Skip to content

Commit

Permalink
Merge pull request #3933 from lsst-sqre/tickets/DM-47814
Browse files Browse the repository at this point in the history
DM-47814: Allow turning off central repo export in Prompt Processing
  • Loading branch information
kfindeisen authored Nov 27, 2024
2 parents 812756a + 93ac0ea commit 013398c
Show file tree
Hide file tree
Showing 6 changed files with 21 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ prompt-proto-service:
endpointUrl: https://usdf-rsp-dev.slac.stanford.edu/sasquatch-rest-proxy
auth_env: false

# A cache efficiency workaround breaks on RC2 tests; see DM-43205.
cacheCalibs: false
debug:
# A cache efficiency workaround breaks on RC2 tests; see DM-43205.
cacheCalibs: false

fullnameOverride: "prompt-proto-service-hsc"
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ prompt-proto-service:
endpointUrl: https://usdf-rsp-dev.slac.stanford.edu/sasquatch-rest-proxy
auth_env: false

# A cache efficiency workaround breaks when mixing observing dates; see DM-43205, DM-43913.
cacheCalibs: false
debug:
# A cache efficiency workaround breaks when mixing observing dates; see DM-43205, DM-43913.
cacheCalibs: false

fullnameOverride: "prompt-proto-service-latiss"
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ prompt-proto-service:
endpointUrl: https://usdf-rsp-dev.slac.stanford.edu/sasquatch-rest-proxy
auth_env: false

# A cache efficiency workaround breaks when mixing observing dates; see DM-43205, DM-43913.
cacheCalibs: false
debug:
# A cache efficiency workaround breaks when mixing observing dates; see DM-43205, DM-43913.
cacheCalibs: false

fullnameOverride: "prompt-proto-service-lsstcomcam"
3 changes: 2 additions & 1 deletion charts/prompt-proto-service/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@ Event-driven processing of camera images
| cache.maxFilters | int | `20` | The maximum number of datasets of a given type the service might load if the filter is unknown. Should be greater than or equal to the number of filters that have e.g. flats or transmission curves. |
| cache.patchesPerImage | int | `4` | A factor by which to multiply `baseSize` for templates and other patch-based datasets. |
| cache.refcatsPerImage | int | `4` | A factor by which to multiply `baseSize` for refcat datasets. |
| cacheCalibs | bool | `true` | Whether or not calibs should be cached between runs of a pod. This is a temporary flag that should only be unset in specific circumstances, and only in the development environment. |
| containerConcurrency | int | `1` | The number of Knative requests that can be handled simultaneously by one container |
| debug.cacheCalibs | bool | `true` | Whether or not calibs should be cached between runs of a pod. This is a temporary flag that should only be unset in specific circumstances, and only in the development environment. |
| debug.exportOutputs | bool | `true` | Whether or not pipeline outputs should be exported to the central repo. This flag does not turn off APDB writes or alert generation; those must be handled at the pipeline level or by setting up an alternative destination. |
| fullnameOverride | string | `"prompt-proto-service"` | Override the full name for resources (includes the release name) |
| image.pullPolicy | string | `IfNotPresent` in prod, `Always` in dev | Pull policy for the PP image |
| image.repository | string | `"ghcr.io/lsst-dm/prompt-service"` | Image to use in the PP deployment |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,9 @@ spec:
- name: FILTERS_WITH_CALIBS
value: {{ .Values.cache.maxFilters | toString | quote }}
- name: DEBUG_CACHE_CALIBS
value: {{ if .Values.cacheCalibs }}'1'{{ else }}'0'{{ end }}
value: {{ if .Values.debug.cacheCalibs }}'1'{{ else }}'0'{{ end }}
- name: DEBUG_EXPORT_OUTPUTS
value: {{ if .Values.debug.exportOutputs }}'1'{{ else }}'0'{{ end }}
volumeMounts:
- mountPath: /tmp-butler
name: ephemeral
Expand Down
10 changes: 7 additions & 3 deletions charts/prompt-proto-service/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,13 @@ fullnameOverride: "prompt-proto-service"
# -- The number of Knative requests that can be handled simultaneously by one container
containerConcurrency: 1

# -- Whether or not calibs should be cached between runs of a pod.
# This is a temporary flag that should only be unset in specific circumstances, and only in the development environment.
cacheCalibs: true
debug:
# -- Whether or not calibs should be cached between runs of a pod.
# This is a temporary flag that should only be unset in specific circumstances, and only in the development environment.
cacheCalibs: true
# -- Whether or not pipeline outputs should be exported to the central repo.
# This flag does not turn off APDB writes or alert generation; those must be handled at the pipeline level or by setting up an alternative destination.
exportOutputs: true

# -- Kubernetes YAML configs for extra container volume(s).
# Any volumes required by other config options are automatically handled by the Helm chart.
Expand Down

0 comments on commit 013398c

Please sign in to comment.