-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tickets/DM-46157: Move Nublado Client into Nublado monorepo #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athornton
force-pushed
the
tickets/DM-46157
branch
4 times, most recently
from
September 17, 2024 23:19
65545cb
to
d59e30e
Compare
athornton
force-pushed
the
tickets/DM-46157
branch
from
September 17, 2024 23:21
d59e30e
to
c2ccfed
Compare
athornton
force-pushed
the
tickets/DM-46157
branch
from
September 19, 2024 15:48
b7dd583
to
6f2c8d4
Compare
jonathansick
requested changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the comments are ideas/suggestions, but the critical one that needs to be fixed is putting the dependencies in pyproject.toml and dropping the requirements/main.txt
file.
stvoutsin
requested changes
Sep 20, 2024
stvoutsin
reviewed
Sep 20, 2024
stvoutsin
reviewed
Sep 20, 2024
athornton
force-pushed
the
tickets/DM-46157
branch
from
September 20, 2024 22:21
99ef988
to
577c8f4
Compare
athornton
force-pushed
the
tickets/DM-46157
branch
from
September 20, 2024 22:48
1d976c9
to
36d8f8e
Compare
stvoutsin
reviewed
Sep 21, 2024
stvoutsin
approved these changes
Sep 21, 2024
jonathansick
approved these changes
Sep 23, 2024
Except I hadn't pushed that pyproject.toml update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines the features of the somewhat-diverged Mobu and Noteburst clients, and moves the whole thing into the Nublado monorepo.
Ghostwriter is the only current customer, and I imagine we will find some bugs as we rework Mobu and Noteburst to use the unified client. More with Noteburst, most likely, since this is very close to the Mobu client.