Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tickets/DM-46157: Move Nublado Client into Nublado monorepo #401

Merged
merged 21 commits into from
Sep 23, 2024

Conversation

athornton
Copy link
Member

This combines the features of the somewhat-diverged Mobu and Noteburst clients, and moves the whole thing into the Nublado monorepo.

Ghostwriter is the only current customer, and I imagine we will find some bugs as we rework Mobu and Noteburst to use the unified client. More with Noteburst, most likely, since this is very close to the Mobu client.

@athornton athornton force-pushed the tickets/DM-46157 branch 4 times, most recently from 65545cb to d59e30e Compare September 17, 2024 23:19
Copy link
Member

@jonathansick jonathansick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the comments are ideas/suggestions, but the critical one that needs to be fixed is putting the dependencies in pyproject.toml and dropping the requirements/main.txt file.

docs/dev/client.rst Outdated Show resolved Hide resolved
docs/dev/client.rst Outdated Show resolved Hide resolved
docs/dev/client.rst Outdated Show resolved Hide resolved
docs/dev/client.rst Outdated Show resolved Hide resolved
docs/dev/client.rst Outdated Show resolved Hide resolved
docs/dev/client.rst Outdated Show resolved Hide resolved
client/pyproject.toml Outdated Show resolved Hide resolved
client/src/rubin/nublado/client/__init__.py Show resolved Hide resolved
client/src/rubin/nublado/client/exceptions.py Outdated Show resolved Hide resolved
client/pyproject.toml Outdated Show resolved Hide resolved
docs/client/index.rst Outdated Show resolved Hide resolved
docs/client/index.rst Outdated Show resolved Hide resolved
docs/client/index.rst Outdated Show resolved Hide resolved
client/src/rubin/nublado/client/nubladoclient.py Outdated Show resolved Hide resolved
client/src/rubin/nublado/client/nubladoclient.py Outdated Show resolved Hide resolved
docs/client/index.rst Outdated Show resolved Hide resolved
client/pyproject.toml Show resolved Hide resolved
@athornton athornton merged commit 21fd24a into main Sep 23, 2024
9 checks passed
@athornton athornton deleted the tickets/DM-46157 branch September 23, 2024 17:21
@athornton
Copy link
Member Author

Except I hadn't pushed that pyproject.toml update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants