Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do all notebook filtering in the business, not in the CI job #362

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Do all notebook filtering in the business, not in the CI job #362

merged 3 commits into from
Jul 23, 2024

Commits on Jul 23, 2024

  1. Do all notebook filtering in the business, not in the CI job 

    * This is nice because it is easier to understand and less error prone
* This stinks because a job that didn't find any notebooks to run will look just like a job that successfully ran notebooks

I'd like to mark the check run as neutral in this case, but I think it
can wait until another PR.
    @fajpunk
    fajpunk committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    72c6dd8 View commit details
    Browse the repository at this point in the history

  2. Remove exclude_dirs option from NotebookRunner options 

    Which means it can no longer be set in the autostart config.
`exclude_dirs must be set in an in-repo `mobu.yaml` config file now.
    @fajpunk
    fajpunk committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    177bd7d View commit details
    Browse the repository at this point in the history

  3. Custom exception for invalid in-repo config file

    @fajpunk
    fajpunk committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    1327bb0 View commit details
    Browse the repository at this point in the history