DM-45709: Don't run notebooks in environments that don't have the necessary services #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fajpunk
force-pushed
the
tickets/DM-45079/add-service-specific-checks
branch
from
4cf5460
to
9ca39d3
Compare
…vices * Parse a 'mobu' section out of notebook metadata * Add a list of available services to app config (to be replaced by some kind of service discovery at some point * Don't run the notebook if it declares required services in the metadata and the services aren't available in the environment.
fajpunk
force-pushed
the
tickets/DM-45079/add-service-specific-checks
branch
from
9ca39d3
to
ad6af66
Compare
rra
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
This change looks good! A couple of general notes:
- You can set
model_config = SettingsConfigDict(env_prefix="MOBU_", case_sensitive=False)in theConfigmodel and then if the environment variable name is the same as the field name except in all caps withMOBU_prepended, you can leave off the explicitvalidation_alias. - We should at some point (not in this PR) figure out a better test strategy that can tie execution results to specific notebooks and make each new test a bit more succinct rather than having to copy and paste large blocks of status information to compare against.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting the required services in the notebook metadata can be done in JupyterLab, though is not the nicest UX for this. We now have an in-repo config file (mobu.yaml), maybe it would be better to keep a manifest in there? I like having it closer to the notebook though. I'm open to other suggestions.