Merge pull request #377 from lsst-sqre/tickets/DM-46480

Be more cautious about cell 'id'

Dockerfile

@@ -12,7 +12,7 @@
 #   - Runs a non-root user.
 #   - Sets up the entrypoint and port.
 
-FROM python:3.12.7-slim-bookworm as base-image
+FROM python:3.12.7-slim-bookworm AS base-image
 
 # Update system packages
 COPY scripts/install-base-packages.sh .

changelog.d/20241029_105636_athornton_DM_46480.md

@@ -0,0 +1,5 @@
+<!-- Delete the sections that don't apply -->
+
+### Bug fixes
+
+- cell["id"] is not always set: be more cautious

src/mobu/services/business/notebookrunner.py

@@ -296,14 +296,11 @@ async def execute_code(self, session: JupyterLabSession) -> None:
 
             for cell in self.read_notebook(self._notebook):
                 code = "".join(cell["source"])
-                if "id" in cell:
-                    cell_id = f'`{cell["id"]}` (#{cell["_index"]})'
-                else:
-                    cell_id = f'#{cell["_index"]}'
+                cell_id = cell.get("id") or cell["_index"]
                 ctx = CodeContext(
                     notebook=self._notebook.name,
                     path=str(self._notebook),
-                    cell=cell["id"],
+                    cell=cell_id,
                     cell_number=f"#{cell['_index']}",
                     cell_source=code,
                 )