Add 'final' and 'strip' to hooks, rework 'ensure_lab' and github on demand #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athornton
force-pushed
the
tickets/DM-46954
branch
3 times, most recently
from
6826bde to
6bb795d
Compare
athornton
force-pushed
the
tickets/DM-46954
branch
from
6bb795d to
dc6ea32
Compare
athornton
changed the title
athornton
changed the title
stvoutsin
approved these changes
Oct 22, 2024
| @@ -21,7 +21,7 @@ To signal failure, a hook should raise an ``Exception``. | |||
| If a hook does not wish to modify the parameters used by future hooks or | |||
There was a problem hiding this comment.
There's a typo (not in your recent changes) just above:
modififactions -> modifications
|
|
||
|
|
||
| async def github_notebook(params: Parameters) -> Parameters | None: | ||
| async def github_notebook(params: Parameters) -> Parameters: |
There was a problem hiding this comment.
Perhaps a suggestion for when you have more development effort on this would be splitting the path processing here to its own method and writing some tests for that to make sure it can handle all unusual cases of paths
athornton
force-pushed
the
tickets/DM-46954
branch
from
160b528 to
7644e54
Compare
stvoutsin
reviewed
Oct 22, 2024
Comment on lines
+48
to
+54
| prefix = "notebooks/github.com/" | ||
| if path.startswith(prefix): | ||
| # Needs stripping | ||
| path = path[(len(prefix)) :] | ||
| if path.endswith(".ipynb"): | ||
| # Also needs stripping | ||
| path = path[: -(len(".ipynb"))] |
There was a problem hiding this comment.
Wondering if this would be simpler:
path = path.removeprefix("notebooks/github.com/").removesuffix(".ipynb")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.