DM-46399: Rework handling of missing state during login #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the authentication state is missing entirely, not incorrect, during return from authentication, the most likely explanation is that the user attempted multiple simultaneous logins and then finished the authentication in another browser window, thus invalidating the state. In this case, redirect the user to their destination without further processing. If they did authentication separately, this is the (mostly) correct thing to do; they will go to the authenticated page, although their session might not be as currently as they would like. If they're not authenticated, this will restart the authentication process with new state, which should be the correct thing to do. There is some risk of a redirect loop, but hopefully we won't go through that loop more than once, so browsers should cope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the authentication state is missing entirely, not incorrect, during return from authentication, the most likely explanation is that the user attempted multiple simultaneous logins and then finished the authentication in another browser window, thus invalidating the state.
In this case, redirect the user to their destination without further processing. If they did authentication separately, this is the (mostly) correct thing to do; they will go to the authenticated page, although their session might not be as currently as they would like.
If they're not authenticated, this will restart the authentication process with new state, which should be the correct thing to do. There is some risk of a redirect loop, but hopefully we won't go through that loop more than once, so browsers should cope.