DM-45858: Add service parameter to the auth endpoint #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rra
force-pushed
the
tickets/DM-45858
branch
3 times, most recently
from
3dd84bc
to
b8d937a
Compare
Add a top-level service configuration attribute to GafaelfawrIngress and a service parameter to the auth endpoint. Use this instead of delegate_to for logging. This is currently optional but will become mandatory in the future. If internal token delegation is enabled in GafaelfawrIngress, the value of the service attribute in the delegation configuration must match the top-level service attribute. The service attribute inside the delegation configuration will be removed in the future. If service and delegate_to are set as parameters to the auth endpoint, they must have the same values.
Filter out a new warning from seleniumwire and remove some filters that are no longer needed.
Use the current URL of the Ruff documentation, and remove the link to Docker Hub since images are no longer uploaded there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a top-level service configuration attribute to GafaelfawrIngress and a service parameter to the auth endpoint. Use this instead of delegate_to for logging. This is currently optional but will become mandatory in the future.
If internal token delegation is enabled in GafaelfawrIngress, the value of the service attribute in the delegation configuration must match the top-level service attribute. The service attribute inside the delegation configuration will be removed in the future.
If service and delegate_to are set as parameters to the auth endpoint, they must have the same values.