add port as variable and fix paths #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csilva-cl
commented
Dec 20, 2023
csilva-cl
commented
- s3daemon port can be changed but defaults to 15555
- some path fixes
- add support text when doing repeats of transfers
womullan
reviewed
Dec 20, 2023
| @@ -8,27 +8,26 @@ source venv/bin/activate | |||
|
|
|||
|
|
|||
|
|
|||
| total=2 | |||
| repeat=2 | |||
There was a problem hiding this comment.
i switched away from this to total files - the number of files is not the same on each machine so if you use repeat the stats. So this change will mess up the plots when you run for large numbers.
It is better to state 200 files not reapet x files 10 times where you do not know what x is ..
womullan
requested changes
Dec 20, 2023
ktlim
reviewed
Dec 21, 2023
| @@ -36,7 +36,7 @@ | |||
| ), | |||
| ) | |||
|
|
|||
| PORT = 15555 | |||
| PORT = int(os.environ["S3DAEMON_PORT"]) | |||
There was a problem hiding this comment.
If you want the port to truly default to 15555 even if nothing is specified, this can be:
PORT = int(os.environ.get("S3DAEMON_PORT", 15555))
|
I'm fine with the port env var. |
|
@csilva-cl I think you can close this now - Josh has the ports and as I explained the other is not good |
|
@csilva-cl perhaps close - obsoloete now ? |
|
obsolete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.