Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-42076: Add script for one-shot collections migration #29

Merged
merged 9 commits into from
Dec 15, 2023

Conversation

andy-slac
Copy link
Collaborator

New script migrates schema from NameKeyCollectionManager to SynthIntKeyCollectionManager, replacing collection names with integer IDs. Tested on a copy of main repo at USDF.

Checklist

  • added documentation for a new migration script

INI file specified only couple of useful options and those are actually fixed
and are easier to setup when constructing configuration manually.
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (59d4c9b) 56.02% compared to head (a3771cf) 54.37%.

Files Patch % Lines
python/lsst/daf/butler_migrate/naming.py 0.00% 29 Missing ⚠️
.../lsst/daf/butler_migrate/script/migrate_history.py 0.00% 9 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   56.02%   54.37%   -1.66%     
==========================================
  Files          32       33       +1     
  Lines        1112     1144      +32     
  Branches      254      256       +2     
==========================================
- Hits          623      622       -1     
- Misses        455      488      +33     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not going to pretend I looked at every line, but I did look at the algorithmic section and it looked okay.

@andy-slac andy-slac merged commit 7ce1343 into main Dec 15, 2023
8 checks passed
@andy-slac andy-slac deleted the tickets/DM-42076 branch December 15, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants