-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to support mqtt based triggers #33
Conversation
…qtt triggers. The controller should now work with the upcomming release of zigbee2mqtt 2.0.0 as triggers were refactored to use mqtt rather than the depecrated sensor.<DEVICE>_action.
Hiya! Tested my E2001/E2002 and appears to be working perfectly so far! Edit: That's alone and with the Light Hook 👍 |
Good to know my code actually works :) I think my changes are pretty easy to follow. If yiu want do one of the phillips or xiomi and I can check it for you. |
For anyone else looking to commit: I would say you should access @yarafie 's repo as per my note above and commit a change to keep this within the same pull too. |
Remove "reported to work with" as Rodret has been moved out to it's own blueprint now.
Looks like all my changes made it as part of the latest PR. Check my code changes (use the ikea_e1743.yaml) as the base. |
I had started looking at a Phillips controller this morning - I'll try get one done today. |
Hey @yarafie |
Changed Versiom to 2025-01-01 Happy New Year
Thanks. Fixed it. |
Updated ikea_e1744.yaml version to tomorrows date to resolve merge conflict. This also makes it clear that the fix from #29 is applied - I know it was there already :) |
Prettier - Enforce code style
To all whom are using my fork. |
@yarafie @Nicolai- thanks for sorting out the issues with the already open fork, and for opening the PR on the original repo! :) For anyone following this thread: Initial PR for MQTT Device triggers for the IKEA E1743 has been opened. 🔥 As soon as we merge that, we are gonna follow up with PRs for all the other controllers. |
Great work guys, highly appreciated! If testing is needed, I will gladly help with: |
Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! 🎉
Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.
Sections marked as * are required and need to be filled in.
Breaking change
This may break existing automations based on the older version for IKEA Tradfri E1743 if being used.
A redownload/update/resetup of the ikea_1743.yaml will probably be needed.
Proposed change*
Updated IKEA TRÅDFRI On/Off Switch & Dimmer (E1743) controller to additionally use mqtt triggers.
Original entity sensor.<DEVICE>_action triggers will still work if that is how your system is setup.
Added new controller for IKEA RODRET Dimmer (E2202).
Updated light, cover and media_player hooks to add support for IKEA RODRET Dimmer (E2202).
The new 2 controllers should now work with future releases of zigbee2mqtt 2.0.0 if and when triggers are refactored to use mqtt rather than the soon to be depecrated sensor.<DEVICE>_action.
Checklist*
npm run format
before submitting my Pull Request.