Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggest wording whitepaper page #5

Merged
merged 4 commits into from
Mar 28, 2025
Merged

Conversation

bbrcknl
Copy link
Collaborator

@bbrcknl bbrcknl commented Mar 16, 2025

No description provided.

@bbrcknl bbrcknl requested review from lsf37 and june-andronick March 16, 2025 23:56
Comment on lines 25 to 27
seL4 is a high-assurance, high-performance operating system microkernel. Its
uniqueness lies in the comprehensive formal [verification](../Verification/),
while maintaining high [performance](Performance/). seL4 was designed as a
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the change for the second sentence, but the first sentence should stay as is. It is unique is the main message of the first part of that sentence and its uniqueness lies in makes the uniqueness a side issue. compromising performance is what (some) people are afraid of. Maintaining high performance assumes that something already has high performance, but for microkernels that is not a given.

Copy link
Collaborator

@june-andronick june-andronick Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also prefer not changing that 1st sentence for the reasons Gerwin mentions. In the second sentence, I would have present tense "seL4 is designed as.." (else it could be interpreted as it's not true anymore...)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. I found the crux of first sentence "It is unique without compromising performance" a little unclear. When I read it, I questioned why an unique technology would compromise performance. (Nit-picking, I know. :-))

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also prefer not changing that 1st sentence for the reasons Gerwin mentions. In the second sentence, I would have present tense "seL4 is designed as.." (else it could be interpreted as it's not true anymore...)

"seL4 is designed as.." (else it could be interpreted as it's not true anymore...)
I have the usual issue with past/present tense here. I.e. I don't necessarily agree that "seL4 is designed as" equates to "seL4 has already been designed, and continues to be designed"
(I'm not suggesting writing the latter one, but I think it's what you're saying.)
What about saying "seL4 is a trustworthy foundation for building safety- and security-critical systems."?
It's factual and avoids the tense issue.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seL4 is a trustworthy foundation for building safety- and security-critical systems.

👍 Let's use that one.

I need to re-read the paragraph in context to make sure it still flows, but it fixed the issue that was there before, and we can still tweak more later if it turns out it is needed.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out that did not work well in the flow, because we have too many sentences with "seL4 is " already and the way we use them it would at least need a new paragraph. I think "is designed" is not great, but acceptable. It's passive, so it doesn't say when it was designed, it just describes the current state. And the tense does fit the rest.

@bbrcknl
Copy link
Collaborator Author

bbrcknl commented Mar 26, 2025

@june-andronick @lsf37 I've reverted your changes, as suggested. :-)
Regarding my comments above - feel free to tell me if I'm being too nit-picky and a general pain in the arse. If you simply want me to revert something (and not ask/comment/argue about it), pls let me know.

@lsf37
Copy link
Owner

lsf37 commented Mar 28, 2025

@june-andronick @lsf37 I've reverted your changes, as suggested. :-) Regarding my comments above - feel free to tell me if I'm being too nit-picky and a general pain in the arse. If you simply want me to revert something (and not ask/comment/argue about it), pls let me know.

👍 It is usually better to figure out why something doesn't work, but we'll let you know.

@lsf37
Copy link
Owner

lsf37 commented Mar 28, 2025

It's about ready to merge. Let me add the fix from above and maybe one more tweak to the VM example before I merged.

@lsf37 lsf37 merged commit 3666d55 into experiments Mar 28, 2025
2 of 5 checks passed
@lsf37 lsf37 deleted the birg-whitepaper-review branch March 28, 2025 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants