Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: bump jQuery to 3.6.0 #1396

Closed
wants to merge 11 commits into from
Closed

[WIP] feat: bump jQuery to 3.6.0 #1396

wants to merge 11 commits into from

Conversation

trivikr
Copy link

@trivikr trivikr commented Aug 31, 2021

Description

Building on top of #1358

  • The generate API reference can be viewed at [netlify-link-to-be-updated-once-ready]
  • The diff between output when bundle exec rake is run at [netlify-link-to-be-updated-once-ready]

A new PR would be cut with squashed commits if required.
I cut this PR originally on fork https://github.com/trivikr/yard/pull/1, but it doesn't run GitHub Actions.

Completed Tasks

  • I have read the Contributing Guide.
  • The pull request is complete (implemented / written).
  • Git commits have been cleaned up (squash WIP / revert commits).
  • I wrote tests and ran bundle exec rake locally (if code is attached to PR).

@trivikr
Copy link
Author

trivikr commented Aug 31, 2021

@lsegal Can you approve workflow to run GitHub actions for this WIP PR?
It would help me to get it into ready state.

@MSP-Greg
Copy link
Contributor

@trivikr

You should be able to turn on Actions in your fork. I might be mistaken, but I think an owner/maintainer needs to approve CI runs for every change to a PR by a new committer...

@trivikr
Copy link
Author

trivikr commented Aug 31, 2021

I might be mistaken, but I think an owner/maintainer needs to approve CI runs for every change to a PR by a new committer...

Nope. The maintainer has to approve CI runs only for first time users.
This has been done to combat bad actors.

You should be able to turn on Actions in your fork.

Do you know how this can be done?
I verified in my fork that Actions permissions are "Allow all actions" by default.

@trivikr
Copy link
Author

trivikr commented Aug 31, 2021

Closing this PR as:

@trivikr trivikr closed this Aug 31, 2021
@trivikr
Copy link
Author

trivikr commented Aug 31, 2021

You should be able to turn on Actions in your fork.

Do you know how this can be done?
I verified in my fork that Actions permissions are "Allow all actions" by default.

Looks like GitHub disables running workflows on fork by default.
I'd to enable them by visiting https://github.com/trivikr/yard/actions

Screenshot

Screen Shot 2021-08-31 at 1 38 56 PM

@trivikr trivikr changed the title feat: bump jQuery to 3.6.0 [WIP] feat: bump jQuery to 3.6.0 Aug 31, 2021
@trivikr trivikr deleted the bump-jquery branch November 3, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants