Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename non-debug to non-release #272

Merged
merged 1 commit into from
May 19, 2020
Merged

Rename non-debug to non-release #272

merged 1 commit into from
May 19, 2020

Conversation

letmaik
Copy link
Contributor

@letmaik letmaik commented May 19, 2020

Aligning terminology to README.

@letmaik letmaik requested a review from prp May 19, 2020 14:10
prp
prp approved these changes May 19, 2020
View reviewed changes
Copy link
Member

@prp prp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hukoyu
hukoyu requested changes May 19, 2020
View reviewed changes
Copy link
Collaborator

@hukoyu hukoyu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nondebug means release. I didn't understand why nonrelease is used instad of nondebug. It should be release. Am I missing something here? @letmaik

@prp
Copy link
Member

prp commented May 19, 2020

nondebug means release. I didn't understand why nonrelease is used instad of nondebug. It should be release. Am I missing something here? @letmaik

@hukoyu no, see #144

hukoyu
hukoyu approved these changes May 19, 2020
View reviewed changes
Copy link
Collaborator

@hukoyu hukoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reading issue #144 Peter shared now it make sense.

@letmaik letmaik merged commit 1769e67 into oe_port May 19, 2020
@letmaik letmaik deleted the letmaik/nondebug-rename branch May 19, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prp prp prp approved these changes

@hukoyu hukoyu hukoyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@letmaik @prp @hukoyu