Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding --debug option to sgx-lkl-java to support debugging #252

Merged
merged 2 commits into from
May 15, 2020
Merged

Adding --debug option to sgx-lkl-java to support debugging #252

merged 2 commits into from
May 15, 2020

Conversation

hukoyu
Copy link
Collaborator

@hukoyu hukoyu commented May 14, 2020

Adding --debug option to sgx-lkl-java to support debugging.
Provide --debug as third option after execution_mode and disk_image if you want to debug

Sample usages:
sgx-lkl-java --hw-debug sgxlkl-java.img --debug
sgx-lkl-java --sw-debug sgxlkl-java.img --debug
sgx-lkl-java --hw-debug sgxlkl-java.img

Note: Below command doesn't work that's why we need to add support to sgx-lkl-java
sgx-lkl-gdb --args sgx-lkl-java --hw-debug sgxlkl-java.img

cc @prp @davidchisnall @letmaik @jxyang

@letmaik
Copy link
Contributor

letmaik commented May 14, 2020

Please see #165

@hukoyu
Copy link
Collaborator Author

hukoyu commented May 14, 2020

Please see #165

@prp and I think we should keep sgx-lkl-java moving forward. And this --debug option will be very helpful debugging java apps.

@hukoyu
Copy link
Collaborator Author

hukoyu commented May 14, 2020

@letmaik I checked pipeline and one LTP test looks failed due to timeout. Not related to this PR. I don't have permission, can you rerun the failed job in the pipeline for this PR? Thanks

Copy link
Contributor

@letmaik letmaik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor remark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants