Tiny contained change to oe_ memory functions #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanTAllen
force-pushed
the
151
branch
2 times, most recently
from
0121233 to
ffcdad1
Compare
|
@SeanTAllen This looks like it's not ready for review yet. Could you make it a draft PR? |
|
@davidchisnall can you have a look at this set of changes for #151? There are additional malloc/calloc/strdup/free calls to replace however, doing so causes some of the test suite to segfault. I spent some time looking at it and haven't found any obvious cause yet. |
This commit removes some of the malloc/calloc/free/strdup libc usage in src/enclave. Not all usage as been removed yet. There are other cases that I have left because when changed, the test suite segfaults for non-obvious reasons that need to be looked into. This commit addresses a small part of #151.
davidchisnall
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.