Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add space for executable construction icon #1068

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mersid
Copy link

@Mersid Mersid commented Jun 25, 2024

Continuation of #1056, which was closed due to incorrect branch. We should find a way to dynamically calculate the size so we don't have to go around adding spaces like this.

Makes executable files go from looking like this:
image

To this:
image

Notice in the original image there's no spacing between the construction crane icon and the file's name.


TODO

  • Use cargo fmt
  • Add necessary tests
  • Update default config/theme in README (if applicable)
  • Update man page at lsd/doc/lsd.md (if applicable)

@Mersid Mersid requested a review from zwpaper as a code owner June 25, 2024 03:30
Copy link

muniu-bot bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Mersid
Once this PR has been reviewed and has the lgtm label, please assign zwpaper for approval by writing /assign @zwpaper in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@muniu-bot muniu-bot bot added the size/XS label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant