Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build with --locked flag in CI #1022

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

orhun
Copy link
Contributor

@orhun orhun commented Mar 25, 2024

$ cargo build -h

--locked Require Cargo.lock is up to date

so that we can catch #1021 before the release 🐻

@orhun orhun requested a review from zwpaper as a code owner March 25, 2024 18:24
@muniu-bot muniu-bot bot added the size/XS label Mar 25, 2024
Copy link

muniu-bot bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: orhun, SuperSandro2000
Once this PR has been reviewed and has the lgtm label, please assign zwpaper for approval by writing /assign @zwpaper in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.34%. Comparing base (575f505) to head (ba49af4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1022   +/-   ##
=======================================
  Coverage   84.34%   84.34%           
=======================================
  Files          53       53           
  Lines        5111     5111           
=======================================
  Hits         4311     4311           
  Misses        800      800           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwpaper zwpaper merged commit 69b28bf into lsd-rs:master Mar 29, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants