-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement
: Redesign Course Cards
#380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this change, the feels much more consistent with web and iOS now 👌
I noticed one issue that has been there before, but maybe it makes sense to tackle it as part of this PR as it should not be a huge change:
The contrast on some course cards is quite bad (eg if the course color is yellow, see screenshot). I know this is also this way on the webapp, but I think we can do better. We could use a simple check with android.graphics.Color.luminance()
to switch the text color to black for bright surfaces. What do you think?
...c/main/kotlin/de/tum/informatics/www1/artemis/native_app/core/ui/common/course/CourseItem.kt
Outdated
Show resolved
Hide resolved
...c/main/kotlin/de/tum/informatics/www1/artemis/native_app/core/ui/common/course/CourseItem.kt
Outdated
Show resolved
Hide resolved
...c/main/kotlin/de/tum/informatics/www1/artemis/native_app/core/ui/common/course/CourseItem.kt
Outdated
Show resolved
Hide resolved
...de/tum/informatics/www1/artemis/native_app/feature/courseregistration/RegisterForCourseUi.kt
Outdated
Show resolved
Hide resolved
I agree with you, however I don't think it's a good idea to deviate from the design of the other platforms. I think all platforms should be consistent regarding this. But I 100% agree with you. My idea would be to maybe discuss this in the meeting. I don't think it's our call to make. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its looking really good and agree with its alignment to web and iOS now 😊.
Works as described ✅
Problem Description
Compared to the iOS app and the web app the dashboard of the Android app does not really fit. Course cards are designed in a different way on all other platforms.
Changes
This PR changes the design of the dashboard and restructures the logic behind course cards and how there are used in the grid layout:
- new icon design for the top bar
- new design for the course enrollment screen
This PR is related to #350, but doesn't close it yet, because I will create a follow up PR to add the recent section.
Steps for testing
Use Artemis test user 2 on TS to test the following:
- Scroll through the dashboard and check if there are any issues with the new design
- Click on an exercise below next exercise if there is any and check if you're redirected to that exercise
- Navigate to the course enrollment screen and check the design for the preview course items
- Login to TS1 or TS to check the Circular Progress that is visible for courses that have started exercises.
Screenshots